Run tests that require tzdata on stan-aarch64-ubuntu#666
Merged
encukou merged 4 commits intopython:mainfrom Feb 20, 2026
Merged
Run tests that require tzdata on stan-aarch64-ubuntu#666encukou merged 4 commits intopython:mainfrom
tzdata on stan-aarch64-ubuntu#666encukou merged 4 commits intopython:mainfrom
Conversation
Member
|
Why not running xpickle and tzdata tests in the same job? Using two jobs means that we clone the Git repository twice and build Python twice. |
vstinner
reviewed
Feb 19, 2026
Member
|
I love the 'oddbals' name :)
…On February 19, 2026 5:20:00 PM GMT+01:00, Victor Stinner ***@***.***> wrote:
@vstinner commented on this pull request.
> @@ -290,10 +290,11 @@ class UnixBigmemBuild(UnixBuild):
factory_tags = ["bigmem"]
-class UnixXPickleBuild(UnixBuild):
- buildersuffix = ".xpickle"
- testFlags = ["-uxpickle", "test_xpickle"]
- factory_tags = ["xpickle"]
+class UnixOddballsBuild(UnixBuild):
+ buildersuffix = ".oddballs"
Maybe use "slow tests" name instead of "oddballs"?
> + testFlags = ["-uxpickle", "test_xpickle",
+ "-utzdata", "test_zoneinfo", "test_datetime"]
You can specify the two test resources as single `-u` argument:
```suggestion
testFlags = ["-u", "xpickle,tzdata",
"test_xpickle", "test_zoneinfo", "test_datetime"]
```
--
Reply to this email directly or view it on GitHub:
#666 (review)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
Co-authored-by: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to the
test_xpickle, these tests are currently not run anywhere, since the'tzdata'resource is excluded from'all'. See python/cpython#99649 for more information.aarch64 Ubuntu test_xpickleonly takes two minutes to run, so I think having both should be ok?